bitshift/bitshift-validate
1
Fork 0
Code Issues 3 Pull Requests Actions Activity

Consider renaming failure.hxx to something else #6

New Issue
Closed
opened 2026-06-26 05:44:27 +02:00 by Onyx · 2 comments
Onyx commented 2026-06-26 05:44:27 +02:00
Owner
Copy Link
Copy Source

Currently it also contains utility classes to pass, ignore, and fail tests explicitly. Consider a rename to something more suitable.

Currently it also contains utility classes to pass, ignore, and fail tests explicitly. Consider a rename to something more suitable.
Onyx added the Kind/Enhancement
Priority
Medium
4
 labels 2026-06-26 05:44:27 +02:00
Onyx commented 2026-06-26 05:45:04 +02:00
Author
Owner
Copy Link
Copy Source

How about signals.hxx and include the word signal in the exception classes names? Except assertion_failure.

How about `signals.hxx` and include the word `signal` in the exception classes names? Except `assertion_failure`.
Onyx commented 2026-06-27 05:39:49 +02:00
Author
Owner
Copy Link
Copy Source

Kept as failure.hxx as part of failure signaling overhaul.

Kept as `failure.hxx` as part of failure signaling overhaul.
Onyx closed this issue 2026-06-27 05:39:49 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is a security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
2
The priority is critical
Priority
CykaBlyat
1
Label used for shit that really hit the fucking fan
Priority
High
3
The priority is high
Priority
Low
5
The priority is low
Priority
Medium
4
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No labels Kind/Enhancement
Priority
Medium
4
Milestone
No items
No Milestone
Assignees
Clear assignees
ryan (Onyx)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bitshift/bitshift-validate#6